私のdotfiles bashスクリプトは何とか自分のディレクトリを削除しますか?

私のdotfiles bashスクリプトは何とか自分のディレクトリを削除しますか?

私はgitを使って複数のコンピュータでドットファイルを追跡します。私は古い既存のドットファイルをバックアップし、各最新のドットファイルへのシンボリックリンクを生成する非常に単純なスクリプトをリポジトリに書きました。スクリプトは次のとおりです。

#!/bin/bash
############################
# makesymlinks.sh
# This script creates symlinks from the home directory to any desired dotfiles in ~/dotfiles
############################

########## Variables

dir=~/dotfiles              # dotfiles directory
olddir=~/dotfiles_old           # old dotfiles backup directory
files="bash_aliases bashrc vimrc"   # list of files/folders to symlink in homedir

##########

# create dotfiles_old in homedir
echo "Creating $olddir for backup of any existing dotfiles in ~"
mkdir -p $olddir

# move any existing dotfiles in homedir to dotfiles_old directory, then create symlinks 
echo "Moving any existing dotfiles from ~ to $olddir"
for file in $files; do
    if [ -f ~/."$file" ]; then
        mv -n ~/."$file" ~/dotfiles_old/    #-n option means don't overwrite existing files in dotfiles_old
    fi

    #if e.g. ~/.vimrc exists after mv command, then this script must've been run before w/ .vimrc included
    if [ -f ~/."$file" ]; then
        echo "Symlink to $dir/$file already exists"
    else
        echo "Creating symlink to $dir/$file in ~"
        ln -s $dir/"$file" ~/."$file"
    fi
done

# source .bashrc
printf "\nTo complete the setup, please run the following command:\n\n"
printf "\tsource ~/.bashrc\n\n"

このスクリプトは通常非常にうまく機能します。今日私が新しいコンピュータで作業を開始している間(重要な場合はTeamViewerを介してリモートで)、このスクリプトを初めて実行したとき、そのディレクトリがあったディレクトリを削除します。私が書いたスクリプトに基づいてこれがどのように実行されるのかわかりませんが、2回目に実行したときにうまくいきました(ストレージを再複製した後)。何が間違っていて、どのように解決しますか?これは子が間違っていますか?エラーの周りのbash端末は次のとおりです(明確にするためにここにいくつかのbashコメントを追加しました)。

drakeprovost@shatterdome:~/RoverCoreOS$ git clone https://github.com/DrakeProvost/dotfiles.git
Cloning into 'dotfiles'...
remote: Enumerating objects: 42, done.
remote: Counting objects: 100% (42/42), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 42 (delta 21), reused 29 (delta 11), pack-reused 0
Unpacking objects: 100% (42/42), done.
drakeprovost@shatterdome:~/RoverCoreOS$ cd dotfiles/
drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ls
bash_aliases  bashrc  makesymlinks.sh  README.md  vimrc
drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ./makesymlinks.sh 
Creating /home/drakeprovost/dotfiles_old for backup of any existing dotfiles in ~
Moving any existing dotfiles from ~ to /home/drakeprovost/dotfiles_old
Creating symlink to /home/drakeprovost/dotfiles/bash_aliases in ~
Creating symlink to /home/drakeprovost/dotfiles/bashrc in ~
Creating symlink to /home/drakeprovost/dotfiles/vimrc in ~

To complete the setup, please run the following command:

    source ~/.bashrc

drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ls
bash_aliases  bashrc  makesymlinks.sh  README.md  vimrc
drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ cd
drakeprovost@shatterdome:~$ ls -al #.bashrc, .vimrc, and .bash_aliases were all red symlinks here, meaning they pointed to non-existent files. Also note that the dotfiles directory has disappeared
total 144
drwxr-xr-x 26 drakeprovost drakeprovost  4096 Jul 19 22:40 .
drwxr-xr-x 12 root         root          4096 Sep 24  2019 ..
lrwxrwxrwx  1 drakeprovost drakeprovost    40 Jul 19 22:40 .bash_aliases -> /home/drakeprovost/dotfiles/bash_aliases
-rw-------  1 drakeprovost drakeprovost 11400 Feb 27 20:01 .bash_history
-rw-r--r--  1 drakeprovost drakeprovost   220 Sep 17  2019 .bash_logout
lrwxrwxrwx  1 drakeprovost drakeprovost    34 Jul 19 22:40 .bashrc -> /home/drakeprovost/dotfiles/bashrc
drwx------ 15 drakeprovost drakeprovost  4096 Oct 15  2019 .cache
drwxr-xr-x  5 drakeprovost drakeprovost  4096 Feb 20 18:08 catkin_ws
drwxr-xr-x  5 drakeprovost drakeprovost  4096 Feb 27 19:23 catkin_ws_PMCurdf
drwx------ 13 drakeprovost drakeprovost  4096 Feb 27 18:57 .config
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Desktop
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Documents
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Jul 19 22:40 dotfiles_old
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Downloads
-rw-r--r--  1 drakeprovost drakeprovost  8980 Sep 17  2019 examples.desktop
drwx------  2 drakeprovost drakeprovost  4096 Oct 15  2019 .gconf
drwx------  3 drakeprovost drakeprovost  4096 Oct 15  2019 .gnupg
-rw-------  1 drakeprovost drakeprovost  2052 Jul 19 22:31 .ICEauthority
drwx------  3 drakeprovost drakeprovost  4096 Oct 15  2019 .local
drwx------  5 drakeprovost drakeprovost  4096 Oct 15  2019 .mozilla
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Music
drwx------  6 drakeprovost drakeprovost  4096 Jul 19 22:31 .nx
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Pictures
-rw-r--r--  1 drakeprovost drakeprovost   807 Sep 17  2019 .profile
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Public
drwx------  2 drakeprovost drakeprovost  4096 Jul 19 22:31 .qt
drwxr-xr-x  4 drakeprovost drakeprovost  4096 Feb 27 19:58 .ros
drwxr-xr-x 11 drakeprovost drakeprovost  4096 Jul 19 22:40 RoverCoreOS
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Feb 13 13:45 .rviz
drwxr-xr-x  3 drakeprovost drakeprovost  4096 Oct 15  2019 snap
drwx------  2 drakeprovost drakeprovost  4096 Oct 15  2019 .ssh
-rw-r--r--  1 drakeprovost drakeprovost     0 Oct 15  2019 .sudo_as_admin_successful
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Templates
drwxr-xr-x  2 drakeprovost drakeprovost  4096 Oct 15  2019 Videos
-rw-------  1 drakeprovost drakeprovost   761 Oct 15  2019 .viminfo
lrwxrwxrwx  1 drakeprovost drakeprovost    33 Jul 19 22:40 .vimrc -> /home/drakeprovost/dotfiles/vimrc
drakeprovost@shatterdome:~$ source ~/.bashrc
bash: /home/drakeprovost/.bashrc: No such file or directory
drakeprovost@shatterdome:~$ git clone https://github.com/DrakeProvost/dotfiles.git
Cloning into 'dotfiles'...
remote: Enumerating objects: 42, done.
remote: Counting objects: 100% (42/42), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 42 (delta 21), reused 29 (delta 11), pack-reused 0
Unpacking objects: 100% (42/42), done.
drakeprovost@shatterdome:~$ cd dotfiles
drakeprovost@shatterdome:~/dotfiles$ ./makesymlinks.sh 
Creating /home/drakeprovost/dotfiles_old for backup of any existing dotfiles in ~
Moving any existing dotfiles from ~ to /home/drakeprovost/dotfiles_old
Creating symlink to /home/drakeprovost/dotfiles/bash_aliases in ~
Symlink to /home/drakeprovost/dotfiles/bashrc already exists
Creating symlink to /home/drakeprovost/dotfiles/vimrc in ~

To complete the setup, please run the following command:

    source ~/.bashrc

drakeprovost@shatterdome:~/dotfiles$ cd
drakeprovost@shatterdome:~$ ls #notice that dotfiles still exists this time
catkin_ws          Documents     Downloads         Pictures     snap
catkin_ws_PMCurdf  dotfiles      examples.desktop  Public       Templates
Desktop            dotfiles_old  Music             RoverCoreOS  Videos
drakeprovost@shatterdome:~$ source ~/.bashrc #this now works like you would expect
drakeprovost@shatterdome:~$ 

ベストアンサー1

あなたの質問に対するコメントの結果は次のとおりです。

drakeprovost@shatterdome:~/RoverCoreOS$ git clone https://github.com/DrakeProvost/dotfiles.git
Cloning into 'dotfiles'...
remote: Enumerating objects: 42, done.
remote: Counting objects: 100% (42/42), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 42 (delta 21), reused 29 (delta 11), pack-reused 0
Unpacking objects: 100% (42/42), done.

~/RoverCoreOS注:上記のコマンドを実行するとディレクトリにあるため、上記のgit cloneコマンドはディレクトリ~/RoverCoreOS/dotfilesではなくディレクトリを作成します~/dotfiles

drakeprovost@shatterdome:~/RoverCoreOS$ cd dotfiles/
drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ls
bash_aliases  bashrc  makesymlinks.sh  README.md  vimrc
drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ./makesymlinks.sh 
Creating /home/drakeprovost/dotfiles_old for backup of any existing dotfiles in ~
Moving any existing dotfiles from ~ to /home/drakeprovost/dotfiles_old
Creating symlink to /home/drakeprovost/dotfiles/bash_aliases in ~
Creating symlink to /home/drakeprovost/dotfiles/bashrc in ~
Creating symlink to /home/drakeprovost/dotfiles/vimrc in ~

To complete the setup, please run the following command:

    source ~/.bashrc

drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ ls
bash_aliases  bashrc  makesymlinks.sh  README.md  vimrc

上記のすべてのことがで起こりました~/RoverCoreOS/dotfiles

drakeprovost@shatterdome:~/RoverCoreOS/dotfiles$ cd

あなたは今ディレクトリにいます~

drakeprovost@shatterdome:~$ ls -al #.bashrc, .vimrc, and .bash_aliases were all red symlinks here, meaning they pointed to non-existent files. Also note that the dotfiles directory has disappeared

~/dotfiles消えたものではなく、存在したこともありません。~/RoverCoreOS/dotfiles存在し、今も存在できる。

...
drakeprovost@shatterdome:~$ git clone https://github.com/DrakeProvost/dotfiles.git
Cloning into 'dotfiles'...
remote: Enumerating objects: 42, done.
remote: Counting objects: 100% (42/42), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 42 (delta 21), reused 29 (delta 11), pack-reused 0
Unpacking objects: 100% (42/42), done.

ディレクトリを作成し、~/dotfilesこれからはすべてが期待どおりに機能します。

いくつかの防御チェックを追加するには、スクリプトを変更することをお勧めします。彼らはあなたが上記のタスクを実行するのを防ぐことはできませんが、少なくともいくつかの問題について警告することができ、上記の問題をキャッチします(dotfiles予想ファイルを含むホームディレクトリに古いディレクトリがないと仮定)。たとえば、

[[ -d "$dir" ]] || { ret="$?"; echo "dir \"$dir\" does not exist"; exit "$ret"; }

for file in $files; do
    [[ -s "$dir/$file" ]] || { ret="$?"; echo "file \"$dir/$file\" does not exist or is empty"; exit "$ret"; }
done

# create dotfiles_old in homedir
echo "Creating $olddir for backup of any existing dotfiles in ~"
mkdir -p "$olddir" || { ret="$?"; echo "Failed to create olddir \"$olddir\""; exit "$ret"; }

必要に応じて他の同様の防御チェックを追加できます。

おすすめ記事